🩹 Do not send link users can't read in problem report resolution #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajowu
force-pushed
the
pajowu/problemreport_dont_sent_unreadable_link
branch
from
dcc5485 to
4469f6d
Compare
krmax44
reviewed
Nov 1, 2024
froide/problem/utils.py
Outdated
| @@ -23,6 +26,14 @@ def inform_managers(report): | |||
| ) | |||
|
|
|||
|
|
|||
| def can_read(user, foirequest): | |||
| request_factory = RequestFactory() | |||
There was a problem hiding this comment.
This just feels a bit odd to me. Should we refactor froide/helper/auth.py, such that it takes a user directly, instead of a request object?
There was a problem hiding this comment.
Request is needed because of possible session tokens and OAuth stuff that doesn't live on the user. But maybe we need a helper that makes creating a fake request for a user more convenient.
stefanw
requested changes
Nov 22, 2024
froide/problem/utils.py
Outdated
| request = request_factory.get(foirequest.get_absolute_url()) | ||
| request.user = user | ||
|
|
||
| can_read_foirequest(foirequest, request) |
pajowu
force-pushed
the
pajowu/problemreport_dont_sent_unreadable_link
branch
from
4469f6d to
6ce015d
Compare
pajowu
force-pushed
the
pajowu/problemreport_dont_sent_unreadable_link
branch
from
6ce015d to
6925ef2
Compare
pajowu
force-pushed
the
pajowu/problemreport_dont_sent_unreadable_link
branch
from
6925ef2 to
1bb5afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.