Fix 5746 #2
Draft
Fix 5746 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akes the solution more robust.
### Description - Use .NET 8.0 instead of 6.0 throughout the project - Make the ordering of diagnostics deterministic even when multiple diagnostics differ only in their related locations ### How has this been tested? - Updated existing tests to match well-defined ordering <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small> --------- Co-authored-by: Remy Willems <[email protected]>
Co-authored-by: Mikaël Mayer <[email protected]>
Fixes dafny-lang/ide-vscode#514 ### What was changed? Set a default verification time limit ### How has this been tested? Added a CLI test that checks there is a default time-out <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
### What was changed? - Remove the `<RuntimeIdentifier>$(RUNTIME_IDENTIFIER)</RuntimeIdentifier>` property from csproj files that was needed as a workaround but may break things in .NET 8 according to SO - Remove references from DafnyDriver to DafnyServer, that prevented publishing correctly with .NET 8 - Stop publishing DafnyLanguageServer since it's not used directly. ### How has this been tested? Tested by existing tests <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
### What was changed? The Dafny legacy CLI shows part of a .NET error message as part of it UI. This can not be tested well since the specific error message is not defined as part of .NET, and can be different across .NET versions and platforms. On Windows it returns: `Invalid filename: The value cannot be an empty string. (Parameter 'path')` On other platforms it is: `Invalid filename: The path is empty. (Parameter 'path')` Instead of fixing the legacy CLI to remove the ambiguity, I'm removing the test for that ambiguous behavior since the old CLI is deprecated. ### How has this been tested? Removed a test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.