-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in the Milestone view #15
base: master
Are you sure you want to change the base?
Conversation
jeffersoncardoso
commented
Feb 6, 2019
- Showing project name on the table
- Create specific column for task column
- Showing task count on the table
Great, I will check that soon! |
@oliviermaridat kind reminder ;) |
Template/milestone/table.php
Outdated
@@ -131,6 +128,9 @@ | |||
<tr> | |||
<th colspan="4" class="total"><?= t('Total time tracking') ?></th> | |||
<td<?php if ($editable): ?> colspan="2"<?php endif ?>> | |||
|
|||
<strong><?= count($milestone) ?></strong> <?= strtolower(t('Tasks')) ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving this number of tasks directly into the progress bar l.148?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great too.
Template/milestone/table.php
Outdated
<table class="task-links-table table-stripped"> | ||
<thead> | ||
<tr> | ||
<th class="column-45" colspan="2"><?= t('Title') ?></th> | ||
<th><?= t('Project') ?></th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of the Milestone view was to kept the "spirit" of the subtask view. This was possible only by keeping it simple, and that's why I finally removed project name and column (and I never tried to add swimlane). But I agree that these are missing. Do you have a screenshot of the result please? (showing also subtasks)
Another idea could be to forget the subtask view and use the list view instead (which contains everything, so great!).
Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this plugin at my company (a brazilian public agency) for the sprint management and is enough for our needs, but for many projects at the same time only the project name and column were missing.
Thinking about improvements, would be really useful have a way to order tasks by table columns (datatable like).
Thanks for the PR @jeffersoncardoso ! I really like the two last commits. I have some concerns regarding the first one. Could you have a look at my comment please? Thanks again! |
Foi adicionado um id (table-sort) para que outras tabela não sejam comprometidas com as alterações
… campos e corrigindo problema de ordenação nos campos com html
Modificando versão
@oliviermaridat Any updates? |