Fix system theme initialization in main window#43
Open
Aglowgibbon wants to merge 4 commits into
Open
Conversation
…ens its editor immediately. When a key is already selected, the new key inherits the selected key’s algorithm, key type, effective keyset, and hide/show preference, and auto-increments SLN/CKR and Key ID to the next unused value in that effective keyset. The selection/prompt flow lives in ContainerEdit.xaml.cs (line 261) and the save/dirty editor logic lives in ContainerEditKeyControl.xaml.cs (line 782). Duplicate key conflicts are now surfaced passively in the left key list with a warning marker and tooltip, backed by non-serialized UI state on KeyItem.cs (line 87) and the row template in ContainerEdit.xaml (line 39). If the prompt is enabled, saves can still warn before accepting duplicate SLN/CKR or Key ID values. Unsaved key edits now prompt on key switches, tab switches, and dialog close. I exposed the “never show again” behavior through menu toggles under Utility > Prompts rather than custom dialog checkboxes, in MainWindow.xaml (line 47), MainWindow.xaml.cs (line 965), and Settings.cs (line 76).
…-found-error Make LoadSettings resilient: use TryParse and sensible defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #41 . It is not specifically the dark/light mode that is the problem, but the "system" option that it starts up on.