Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ruff preview rules to Python scripts #210

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Are all scripts supposed to have switched to Python 3 (except for those in #207)?

F821 Undefined name

This looks like a Python 2 script, but the linter did find a real bug.
F841 Local variable is assigned to but never used
E401 Multiple imports on one line
E713 Test for membership should be `not in`
E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
E722 Do not use bare `except`
@sbesson sbesson self-requested a review January 23, 2025 08:29
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the testing of #198, I did not find any difference in the code-generated sources with and without this PR. CI tests are green

@sbesson sbesson merged commit f6a81fc into ome:master Jan 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants