Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ruff format to Python code #217

Closed

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@sbesson
Copy link
Member

sbesson commented Feb 10, 2025

Thanks for the contribution. However after discussion with the @ome/formats team, the general consensus is in addition to being a significant cost in terms of reviewing this PR which modifies thousands of lines of code, the value of enforcing a Python formatting style is not worth it at this stage.

@sbesson sbesson closed this Feb 10, 2025
@DimitriPapadopoulos DimitriPapadopoulos deleted the ruff_format branch February 10, 2025 18:22
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Feb 10, 2025

I understand. The idea was to not to review the PR. Instead, a maintainer could have rerun ruff format locally and verified that the generated Java code is identical. While not all ruff check fixes are safe, ruff format is supposed to be totally safe - it merely reformats code (spaces, line breaks, etc.) without any substantial modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants