Labeled multiscales #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Sep 3, 2020
There was a problem hiding this comment.
Overall, the changes are sensible, in agreement with the discussion of the last few weeks. A few inline comments. Happy to discuss them and convert them as issues/follow-up as necessary.
While reviewing this in relationship with ome/ome-zarr-py#45, one additional confusion is that this document defines the overall layout as specification and the individual schemas for the .zattrs keys as metadata while ome/ome-zarr-py#45 introduces the concept of Spec for the latter.
This was referenced Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captures the changes to the spec for turning labeled images into multiscale arrays. Depending on the decisions around color etc. (see #62 (comment)) this may include a top-level "label" key.
see ome/ome-zarr-py#45