-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rocky Linux 9 #93
Conversation
for more information, see https://pre-commit.ci
…haledk2/omero_search_engine into secure_elasticsearch_onnection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing the Dockerfile with the one used for CentOS7, it looks like there are additional requirements (openssl-devel,
libffi-devel,
libpq-devel`). Is that on purpose?
I assume the mid-term intent is to update https://github.com/ome/omero_search_engine/blob/main/.github/workflows/main.yml#L84 and use Rocky Linux 9 as the base image for the container used by IDR in production? Possibly a topic for an upcoming Monday meeting, it would be useful to discuss the integration timeline into the upcoming IDR releases.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secure the connection with the elsticsearch
Co-authored-by: jean-marie burel <[email protected]>
add tag 0.5.3 to changelog
@@ -0,0 +1,3 @@ | |||
Dockerfile | |||
.git | |||
.gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need an extra line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am not sure what you mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add an empty line at the end of the file?
I think it should be helpful for testing and debugging. |
I have added a subfolder (rockylinux) to the docker folder, it contains the required files to create a rockylinux 9 docker image. I have installed a rocky Linux version 9.2 on an old laptop (8 GB RAM, i5-8350U CPU) I have created a rocky Linux docker image and tested it on the laptop and it seems to be working fine.