Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rocky Linux 9 #93

Merged
merged 23 commits into from
Feb 28, 2024
Merged

Support Rocky Linux 9 #93

merged 23 commits into from
Feb 28, 2024

Conversation

khaledk2
Copy link
Collaborator

@khaledk2 khaledk2 commented Sep 3, 2023

I have added a subfolder (rockylinux) to the docker folder, it contains the required files to create a rockylinux 9 docker image. I have installed a rocky Linux version 9.2 on an old laptop (8 GB RAM, i5-8350U CPU) I have created a rocky Linux docker image and tested it on the laptop and it seems to be working fine.

deployment/docker/rockylinux/Dockerfile Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the Dockerfile with the one used for CentOS7, it looks like there are additional requirements (openssl-devel, libffi-devel, libpq-devel`). Is that on purpose?

I assume the mid-term intent is to update https://github.com/ome/omero_search_engine/blob/main/.github/workflows/main.yml#L84 and use Rocky Linux 9 as the base image for the container used by IDR in production? Possibly a topic for an upcoming Monday meeting, it would be useful to discuss the integration timeline into the upcoming IDR releases.

@khaledk2
Copy link
Collaborator Author

khaledk2 commented Sep 5, 2023

libpq-devel and python3-devel.x86_64 are required to install psycopg2 from source. openssl-devel and libffi-devel were required to install psycopg2 from binaries. I have removed the unused requirements, e.g. ones that were used to build Python from the source.
I have modified the workflow to use the Rocky Linux 9 as the base image.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khaledk2. Barring a reduction in the number of statements in the Dockerfile which could reduce the size of the image, I don't see anything of concern.

Next question for you and @jburel is what is the process and the timeline for testing & integrating this PR?

@@ -0,0 +1,3 @@
Dockerfile
.git
.gitignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need an extra line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am not sure what you mean

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add an empty line at the end of the file?

@khaledk2
Copy link
Collaborator Author

I think it should be helpful for testing and debugging.

@khaledk2 khaledk2 merged commit 0ac51d1 into ome:main Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants