Skip to content

fix attaching styles, check shadowroot#181

Open
definite2 wants to merge 1 commit into
omgovich:masterfrom
definite2:180-fix-styles-shadowroot
Open

fix attaching styles, check shadowroot#181
definite2 wants to merge 1 commit into
omgovich:masterfrom
definite2:180-fix-styles-shadowroot

Conversation

@definite2

Copy link
Copy Markdown

fixes #180

Comment thread src/utils/shadowRoot.ts Outdated
Comment thread src/utils/shadowRoot.ts Outdated
Comment thread src/hooks/useStyleSheet.ts Outdated
Comment thread src/hooks/useStyleSheet.ts
@omgovich

Copy link
Copy Markdown
Owner

Hi! Sorry for the delay: I'm going through a tough time in my life.

I left a few comments, could you take a look?

@definite2 definite2 force-pushed the 180-fix-styles-shadowroot branch from 69fd951 to 41668c1 Compare September 20, 2022 08:13
@definite2

Copy link
Copy Markdown
Author

Hi! Sorry for the delay: I'm going through a tough time in my life.

I left a few comments, could you take a look?

Hi, @omgovich can you check again. I squash the update commit with the previous.

@VitaliyR

Copy link
Copy Markdown

@omgovich hi, hopefully you doing alright, is there any intention to continue development of this lib or perhaps you consider to add somebody as a maintainer?
Would be awesome to merge this PR

@xitij2000

Copy link
Copy Markdown

@omgovich We've run into this issue recently and would love to see this PR merged. What can we do to help move this forward?

@omgovich

Copy link
Copy Markdown
Owner

Hi all, sorry for letting this sit for so long. Diving into it right now — I'll go through the comments and the latest changes today and circle back. Thanks for your patience (and for the nudge)!

@xitij2000

Copy link
Copy Markdown

@omgovich No worries! Thanks for all your time and effort maintaining this. It's truly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-colorful not working if we use it with react-shadow

4 participants