Add user activity logs to messaging endpoint #2691
Conversation
ciremusyoka
force-pushed
the
log-user-profile-activities
branch
2 times, most recently
from
034742a to
5f62acb
Compare
ciremusyoka
force-pushed
the
log-user-profile-activities
branch
from
5f62acb to
6ecbd2e
Compare
| @@ -228,6 +246,17 @@ def create(self, request, *args, **kwargs): | |||
| profile = response.data | |||
| user_name = profile.get("username") | |||
| cache.set(f"{USER_PROFILE_PREFIX}{user_name}", profile) | |||
|
|
|||
| # send notification on creating new user account | |||
| user = User.objects.get(username__iexact=user_name) | |||
There was a problem hiding this comment.
Could we fetch user via the id instead?
user = User.objects.get(id=profile.get("id")
| send_message( | ||
| instance_id=user_name, | ||
| target_id=user.id, | ||
| target_type=USER, | ||
| user=user, | ||
| message_verb=USER_CREATED, | ||
| ) |
There was a problem hiding this comment.
Could we move this directly into the UserProfileSerializer class instead? I think the above additional query for the user will be unnecessary in such a case.
| @@ -211,6 +219,16 @@ def update(self, request, *args, **kwargs): | |||
| username = kwargs.get("user") | |||
| response = super().update(request, *args, **kwargs) | |||
| cache.set(f"{USER_PROFILE_PREFIX}{username}", response.data) | |||
|
|
|||
| # send notification on updating user profile | |||
| send_message( | |||
There was a problem hiding this comment.
We can also move this to the serializer. Since we are sending the messaging for both create and update, we can override the serializer's save method and call send_message there. Example
We can differentiate create from update by checking self.instance. When doing an update self.instance is not None
| @@ -303,6 +330,16 @@ def partial_update(self, request, *args, **kwargs): | |||
|
|
|||
| profile.metadata = metadata | |||
| profile.save() | |||
|
|
|||
| # send notification on updating user profile | |||
| send_message( | |||
There was a problem hiding this comment.
partial_update will call the serializer's save method. If we refactor to send the message for update within the serializer, then we can get rid of sending the message here
Changes / Features implemented
Adds message notifications for the following actions:
Steps taken to verify this change does what is intended
Before submitting this PR for review, please make sure you have:
Closes #