Skip to content

Fix scatter-style local range to distributed range copies #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix scatter-style local range to distributed range copies #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/dr/sp/algorithms/copy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,10 @@ sycl::event copy_async(InputIt first, InputIt last, OutputIt d_first) {
auto local_last = first;
rng::advance(local_last, n_to_copy);

auto &&q = __detail::queue(ranges::rank(segment));

events.emplace_back(
dr::sp::copy_async(first, local_last, rng::begin(segment)));
dr::sp::copy_async(q, first, local_last, rng::begin(segment)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line does not compile, see CI run

/home/runner/work/distributed-ranges/distributed-ranges/include/./dr/sp/algorithms/copy.hpp:126:9: error: no matching function for call to 'copy_async'
  126 |         dr::sp::copy_async(q, first, local_last, rng::begin(segment)));


++segment_iter;
rng::advance(first, n_to_copy);
Expand Down
Loading