-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneMKL samples][computed tomography] Revisions, refactoring and addition of a functional verification #2564
[oneMKL samples][computed tomography] Revisions, refactoring and addition of a functional verification #2564
Conversation
@hparks-intel @dbollapr @intelok @nshamszadeh please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning this up! It looks great. I'm just nitpicking a few things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I don't think it's important to do anything different with the remaining comment about in_pix_len
.
…mmenting source code for computed_tomography sample. README and makefiles updated.
… uncropped images
…gram argument as -h or -H. Remove unnecessary std::flush'es
…notations, slight modification to discrete heaviside
…gned int' in bmp_write
eef399f
to
d76a518
Compare
@andreyfe1, this is ready for you to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreyfe1 Merge PR?
@jimmytwei, let's wait for 1 more day if there is any late feedback |
…ed output (W/A false positives in CI test)
@andreyfe1 @raphael-egan Please let me know when I can merge this and if it should go into the 2025.1 release. If we can do this asap, that'll be great... |
@jimmytwei, the PR is ready to merge |
@raphael-egan @andreyfe1 Merged. Can you also submit the PR to the |
See PR#2639. |
Description
This PR revises the "computed tomography" oneAPI sample.
The sample itself was revised so that the application creates reconstructed signal/image samples that are real (no longer complex) and so that those generated real values are directly comparable to the input image's (gray-scale-converted) values themselves. These changes are motivated by the desire to introduce a legitimate functional validation step (introduced herein as well), but that need triggered more thorough revision(s) of the sample's source code.
Extensive explanatory comments were added to the source code, explaining the mathematical nature of the operations at play and/or the technical details related to the suggested implementation.
Type of change
How Has This Been Tested?
This was extensively tested on a PVC GPU (512 EUs) and a SPR CPU using a machine operating Ubuntu 22.04. The default input file as well as others (not added to this PR) were considered along with an extensive range of input parameters. Due to the nature of the operations at play, one simply cannot guarantee that the mean global error will be below the arbitrarily-chosen threshold for any input file and any choice of (supported) input parameters. However,
The updated sample's default behavior was also successfully tested on a BMG GPU machine operating Windows 11.
Regarding instructions to test or to run the sample with different inputs, please refer to the application's "Usage" information (printed in case of invalid usage).