Update CI to use Docker #1329
Open
Update CI to use Docker #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rbanka1
commented
May 23, 2025
rbanka1
commented
- Updated reusable_basic.yml and reusable_fast.yml to use Docker images.
- Added install_oneAPI.sh to support image setup.
Open
bratpiorka
reviewed
May 26, 2025
bratpiorka
reviewed
May 26, 2025
|
|
||
| - name: Install oneAPI basekit | ||
| if: matrix.compiler.cxx == 'icpx' | ||
| # Installing via script to avoid installing multi-line bash command by root |
There was a problem hiding this comment.
I think this comment is unnecessary details
bratpiorka
reviewed
May 26, 2025
|
@rbanka1 please rebase |
- Updated reusable_basic.yml and reusable_fast.yml to use Docker images. - Added install_oneAPI.sh to support image setup.
- Updated reusable_basic.yml and reusable_fast.yml to use Docker images. - Added install_oneAPI.sh to support image setup.
KFilipek
requested changes
May 26, 2025
| wget https://github.com/Kitware/CMake/releases/download/v${{matrix.cmake_ver}}/cmake-${{matrix.cmake_ver}}-Linux-x86_64.sh | ||
| chmod +x cmake-${{matrix.cmake_ver}}-Linux-x86_64.sh | ||
| sudo ./cmake-${{matrix.cmake_ver}}-Linux-x86_64.sh --skip-license --prefix=/usr/local | ||
| echo ${USERPASS} | sudo -Sk ./cmake-${{matrix.cmake_ver}}-Linux-x86_64.sh --skip-license --prefix=/usr/local |
There was a problem hiding this comment.
Why are you not using root under the container?
There was a problem hiding this comment.
to avoid security issue, @lukaszstolarczuk suggested me this solution
.github/workflows/reusable_basic.yml
Outdated
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/bb-ur/umf-${{ matrix.os }}:latest | ||
| options: --privileged |
There was a problem hiding this comment.
You mean: options: --user root
There was a problem hiding this comment.
no, test_user is default container user I set it on Dockerfile, it is non-root user to avoid security issue
There was a problem hiding this comment.
So give me an explanation why using root user is worse than --priviledged or why not to avoid both of them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.