Skip to content

Enable tests for v2 command buffer #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Enable tests for v2 command buffer #2670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f5c3b3
Enable tests for v2 command buffer
Xewar313 Feb 7, 2025
cccacd2
Add checks to failing tests
Xewar313 Feb 7, 2025
4656916
Move V2 check to test command
Xewar313 Feb 7, 2025
1929e67
Fix indentation
Xewar313 Feb 7, 2025
6bb51a2
Removed nullptr check
Xewar313 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/adapters/level_zero/v2/command_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ urCommandBufferCreateExp(ur_context_handle_t context, ur_device_handle_t device,
ur_exp_command_buffer_handle_t *commandBuffer) try {
checkImmediateAppendSupport(context);

if (commandBufferDesc->isUpdatable &&
if (commandBufferDesc != nullptr && commandBufferDesc->isUpdatable &&
!context->getPlatform()->ZeMutableCmdListExt.Supported) {
throw UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}
Expand Down
10 changes: 0 additions & 10 deletions test/conformance/exp_command_buffer/fixtures.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ static void checkCommandBufferUpdateSupport(

struct urCommandBufferExpTest : uur::urContextTest {
void SetUp() override {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{});

UUR_RETURN_ON_FATAL_FAILURE(uur::urContextTest::SetUp());

UUR_RETURN_ON_FATAL_FAILURE(checkCommandBufferSupport(device));
Expand All @@ -78,8 +76,6 @@ struct urCommandBufferExpTest : uur::urContextTest {
template <class T>
struct urCommandBufferExpTestWithParam : urQueueTestWithParam<T> {
void SetUp() override {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{});

UUR_RETURN_ON_FATAL_FAILURE(uur::urQueueTestWithParam<T>::SetUp());

UUR_RETURN_ON_FATAL_FAILURE(checkCommandBufferSupport(this->device));
Expand All @@ -100,8 +96,6 @@ struct urCommandBufferExpTestWithParam : urQueueTestWithParam<T> {

struct urCommandBufferExpExecutionTest : uur::urKernelExecutionTest {
void SetUp() override {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{});

UUR_RETURN_ON_FATAL_FAILURE(uur::urKernelExecutionTest::SetUp());

UUR_RETURN_ON_FATAL_FAILURE(checkCommandBufferSupport(device));
Expand All @@ -122,8 +116,6 @@ struct urCommandBufferExpExecutionTest : uur::urKernelExecutionTest {

struct urUpdatableCommandBufferExpTest : uur::urQueueTest {
void SetUp() override {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{});

UUR_RETURN_ON_FATAL_FAILURE(uur::urQueueTest::SetUp());

UUR_RETURN_ON_FATAL_FAILURE(checkCommandBufferSupport(device));
Expand Down Expand Up @@ -158,8 +150,6 @@ struct urUpdatableCommandBufferExpTest : uur::urQueueTest {

struct urUpdatableCommandBufferExpExecutionTest : uur::urKernelExecutionTest {
void SetUp() override {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{});

UUR_RETURN_ON_FATAL_FAILURE(uur::urKernelExecutionTest::SetUp());

ASSERT_SUCCESS(urPlatformGetInfo(platform, UR_PLATFORM_INFO_BACKEND,
Expand Down
1 change: 0 additions & 1 deletion test/conformance/exp_command_buffer/release.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCommandBufferReleaseExpTest);

TEST_P(urCommandBufferReleaseExpTest, Success) {
EXPECT_SUCCESS(urCommandBufferRetainExp(cmd_buf_handle));

uint32_t prev_ref_count = 0;
EXPECT_SUCCESS(uur::GetObjectReferenceCount(cmd_buf_handle, prev_ref_count));

Expand Down
Loading