Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

557 feature cache the evm nft list in the background #565

Merged
merged 8 commits into from
Feb 21, 2025

Conversation

zzggo
Copy link
Contributor

@zzggo zzggo commented Feb 21, 2025

Related Issue

Closes #557

Summary of Changes

Need Regression Testing

  • Yes
  • No
    Added a cache to the evm nft list in the background.

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

Copy link
Collaborator

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes to consolidate types and ensure naming is always e.g. getNftId instead of getNFTID. Looks good otherwise.

@zzggo zzggo merged commit 3e1e725 into dev Feb 21, 2025
3 checks passed
@zzggo zzggo deleted the 557-feature-cache-the-evm-nft-list-in-the-background branch February 21, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants