fixed: replace the empty key value with the correct name #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombeckenham
approved these changes
Feb 21, 2025
zzggo
deleted the
555-bug-issue-movingsending-certain-nfts-between-evmcadence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #555
Summary of Changes
Updated the evm component with the correct keyword.
The real reason for not being able to make transactions with certain NFTs was that the contract name was missing in the backend API.
https://test.lilico.app/api/v3/evm/nft/collectionList?network=mainnet&address=0xe9b4047dc79298fd6d32af9b6d616aa9d745a95a&collectionIdentifier=d112634f06902a977db1d596c77715d72f8da8a9&limit=0&offset=0
The contract name has been added
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)