Merge pull request #7050 from onflow/mpeter/fix-evm-block-view-creati…

…on-v2

Update EVM `ViewProvider` to return block `View` at its end state

fvm/evm/offchain/query/viewProvider.go

@@ -33,9 +33,15 @@ func NewViewProvider(
 	}
 }
 
-// GetBlockView returns the block view for the given height
+// GetBlockView returns the block view for the given height (at the end of a block!)
+// The `GetSnapshotAt` function of `storageProvider`, will return
+// the block state at its start, before any transaction executions.
+// This is the intended functionality, when replaying & verifying blocks.
+// However, when reading the state from a block, we are interested
+// in its end state, after all transaction executions.
+// That is why we fetch the block snapshot at the next height.
 func (evp *ViewProvider) GetBlockView(height uint64) (*View, error) {
-	readOnly, err := evp.storageProvider.GetSnapshotAt(height)
+	readOnly, err := evp.storageProvider.GetSnapshotAt(height + 1)
 	if err != nil {
 		return nil, err
 	}