-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port #5653 to feature/atree-inlining-cadence-v0.42 branch #5758
Port #5653 to feature/atree-inlining-cadence-v0.42 branch #5758
Conversation
@fxamacker Looks good, thanks for porting it over! There's a small issue with the dictionary insertion in the test case, I'll push up a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
cmd/util/ledger/migrations/filter_unreferenced_slabs_migration_test.go
Outdated
Show resolved
Hide resolved
cmd/util/ledger/migrations/filter_unreferenced_slabs_migration_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for porting this over and making the required changes 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
cmd/util/cmd/execution-state-extract/execution_state_extract.go
Outdated
Show resolved
Hide resolved
c7e0f38
into
feature/atree-inlining-cadence-v0.42
Work towards #5634
This PR ports #5653 to feature branch
feature/atree-inlining-cadence-v0.42
.@turbolent Some additional changes are needed due to incompatibility in Cadence v0.42 vs v1.0.
For example, in one test, the
InsertWithoutTransfer()
function isn't available in Cadence v0.42. When replacing it withInsert()
, test payload count is increased by 1, but testing unreferenced slabs isn't affected.flow-go/cmd/util/ledger/migrations/filter_unreferenced_slabs_migration_test.go
Lines 99 to 111 in c49d24a