-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] OK response should not contain error message #7037
base: master
Are you sure you want to change the base?
[Access] OK response should not contain error message #7037
Conversation
Co-authored-by: Peter Argue <[email protected]>
…The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…ot-indexed' of github.com:onflow/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…github.com:onflow/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
… illia-malachyn/7009-ok-response-should-not-contain-error-message
… illia-malachyn/7009-ok-response-should-not-contain-error-message
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7037 +/- ##
==========================================
- Coverage 41.14% 41.06% -0.09%
==========================================
Files 2132 2132
Lines 187048 187033 -15
==========================================
- Hits 76966 76808 -158
- Misses 103633 103774 +141
- Partials 6449 6451 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Some tests might fail because of #6907 |
…' of github.com:The-K-R-O-K/flow-go into AndriiSlisarchuk/6573-pending-should-return-immediately
…' into UlianaAndrukhiv/6641-websockets-integration-tests
… illia-malachyn/7009-ok-response-should-not-contain-error-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks good to me!
Branched off #6907
data providers
package.Build()
function with factory method patternNew...()
Closes #7009 #7039