Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] OK response should not contain error message #7037

Open
wants to merge 161 commits into
base: master
Choose a base branch
from

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Feb 14, 2025

Branched off #6907

  • Pass object by pointer rather than by value, so that it is not encoded with zeros but omitted in JSON
  • Move data providers' models to data providers package.
  • Replace Build() function with factory method pattern New...()

Closes #7009 #7039

Guitarheroua and others added 30 commits November 15, 2024 15:18
…The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 64.58333% with 170 lines in your changes missing coverage. Please review.

Project coverage is 41.06%. Comparing base (121c800) to head (0f3da98).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...s/rpc/backend/transaction_subscription_metadata.go 64.03% 31 Missing and 10 partials ⚠️
engine/access/rest/common/utils.go 47.91% 24 Missing and 1 partial ⚠️
engine/access/rest/websockets/controller.go 55.55% 19 Missing and 1 partial ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 17 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 17 Missing ⚠️
.../access/rpc/backend/backend_stream_transactions.go 72.13% 12 Missing and 5 partials ⚠️
engine/access/rest/util/converter.go 0.00% 8 Missing ⚠️
.../rest/websockets/data_providers/events_provider.go 61.53% 4 Missing and 1 partial ⚠️
access/api.go 0.00% 4 Missing ⚠️
...ockets/data_providers/account_statuses_provider.go 72.72% 2 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7037      +/-   ##
==========================================
- Coverage   41.14%   41.06%   -0.09%     
==========================================
  Files        2132     2132              
  Lines      187048   187033      -15     
==========================================
- Hits        76966    76808     -158     
- Misses     103633   103774     +141     
- Partials     6449     6451       +2     
Flag Coverage Δ
unittests 41.06% <64.58%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn illia-malachyn changed the title OK response should not contain error message [Access] OK response should not contain error message Feb 14, 2025
@illia-malachyn illia-malachyn marked this pull request as ready for review February 14, 2025 14:59
@illia-malachyn illia-malachyn requested a review from a team as a code owner February 14, 2025 14:59
@illia-malachyn
Copy link
Contributor Author

Some tests might fail because of #6907

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Empty error object in successful WebSocket subscription responce
5 participants