Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0 Update. Avoid build collisions in the lemonade cache. Improve memory tracking and OGA testing. #288

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

jeremyfowers
Copy link
Collaborator

@jeremyfowers jeremyfowers commented Feb 4, 2025

  • Avoid lemonade build cache collisions (@jeremyfowers).
    • All builds are now placed under <cache_dir>/builds/<build_name> instead of <cache_dir>/<build_name>
      • This creates a more hierarchical cache structure, where builds are peer to models and data.
    • All build names now include a timestamp
      • This ensures that build stats and logs will not collide with each other if we build the same model in the same cache, but with different parameters.
    • Revs the minor version number because all previous caches are invalidated.
  • Enable ONNX model download for cpu and igpu in oga-load (@jeremyfowers)
  • Improvements to memory tracking (@amd-pworfolk)
  • Improve OGA testing (@jeremyfowers).
    • Run the sever test last, since it is the most complex and has the worst telemetry
    • Stop deleting the entire cache directory between every test, since that deletes the model builder cache. Instead, just delete the cache/builds directory.

@jeremyfowers jeremyfowers self-assigned this Feb 4, 2025
Copy link
Collaborator

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeremyfowers jeremyfowers changed the title Improve OGA testing 5.1.0 Update. Avoid build collisions in the lemonade cache. Improve memory tracking and OGA testing. Feb 4, 2025
@jeremyfowers jeremyfowers marked this pull request as ready for review February 4, 2025 20:08
@jeremyfowers jeremyfowers merged commit 0989a7d into main Feb 4, 2025
9 checks passed
@jeremyfowers jeremyfowers deleted the bug/oga_testing branch February 4, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants