Fix: Jump to infinit loading #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
approved these changes
Oct 24, 2024
|
@Bilelkihal, This needs to be fixed here too https://github.com/ontoportal-lirmm/ontologies_api_ruby_client/blob/development/lib/ontologies_api_client/models/class.rb#L81, by returning an Object as before, otherwise, we do breaking change here, to do that your need to wrap the hash by doing |
|
@syphax-bouazzouni Okay |
@Bilelkihal needs to fix the tests here ontoportal-lirmm/ontologies_api_ruby_client#21 before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require: ontoportal-lirmm/ontologies_api_ruby_client#21
Source: agroportal/project-management#619
PR description
After adding the federation to the search, the search results are now returned as a hash instead of an object, so to access to the collection key of the results we need to use
[:collection]instead of.collection