New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : GitHub OAuth Misconfiguration Allows Logging In as Another User #196

Open

muhammedBkf wants to merge 1 commit into ontoportal-lirmm:development from muhammedBkf:fix-github-oauth

muhammedBkf commented Feb 20, 2025

GitHub OAuth Misconfiguration

If email is nil, the query LinkedData::Models::User.where(email: email).first would return the first user in the database, leading to unintended login as that user.
To prevent this, explicitly return nil if email is nil.

Even if we fix this the logic behind Github Oauth is still broken, because i can change my github email (it doesn't require verification) and put one of a portal admin.


          return no user if the email is nil in github oauth

c494ba0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet