Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed InitialFolder + fix bug crash for SaveFileDialog when using root directory #10

Closed
wants to merge 2 commits into from
Closed

Fixed InitialFolder + fix bug crash for SaveFileDialog when using root directory #10

wants to merge 2 commits into from

Conversation

zappu9x
Copy link

@zappu9x zappu9x commented Oct 9, 2019

@augustoproiete augustoproiete mentioned this pull request Oct 9, 2019
Open
@augustoproiete
Copy link
Member

Hi @zappu9x, thanks for submitting this PR.

For #8, see my comment to @soulflyman and lets discuss what the right approach is before introducing any breaking changes.

For #9, I've asked you for more details on reproducing the problem you reported.

I'll close this PR for now, and would appreciate if you could reply to my questions on #9 and send a separate PR to fix #9 specifically, and we can discuss #8 and fix in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need-more-info
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zappu9x @augustoproiete @giapntkp