refactor(api)!: rename accountAlias option to connectionName#1
Conversation
Rename the public `accountAlias` option to `connectionName` to better reflect that it selects a named connection, aligning the SDK surface with the product's terminology. The wire protocol is intentionally untouched: the outgoing header `x-oo-connector-alias`, the gateway response field `alias`, and the `connection_alias_conflict` error code all stay the same, so this is a pure SDK-surface rename with no behavioral change. camelCase is used to stay consistent with the other option fields (`apiKey`, `baseUrl`, `organization`). BREAKING CHANGE: the `accountAlias` field on ClientConfig, CallOptions, ScopeOptions, and ConnectedApp is renamed to `connectionName`. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
Summary by CodeRabbit
WalkthroughThe pull request renames the connection-selector field 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Rename the public
accountAliasoption toconnectionNameto better reflect that it selects a named connection, aligning the SDK surface with the product's terminology.The wire protocol is intentionally untouched: the outgoing header
x-oo-connector-alias, the gateway response fieldalias, and theconnection_alias_conflicterror code all stay the same, so this is a pure SDK-surface rename with no behavioral change.camelCase is used to stay consistent with the other option fields (
apiKey,baseUrl,organization).BREAKING CHANGE: the
accountAliasfield on ClientConfig, CallOptions, ScopeOptions, and ConnectedApp is renamed toconnectionName.