Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): Remove Hardcoded Precompile Addresses #1013

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Feb 6, 2025

Description

Updates kona-client precompiles to use the addresses defined in revm-precompiles.

Reduces the chance that precompile addresses are incorrectly input.

@refcell refcell requested review from clabby and emhane as code owners February 6, 2025 17:15
@refcell refcell self-assigned this Feb 6, 2025
@refcell
Copy link
Collaborator Author

refcell commented Feb 6, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Base automatically changed from rf/fix-de-dup-msm-required-fee-calc to main February 6, 2025 17:16
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.6%. Comparing base (b1c5b9b) to head (219c593).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
bin/client/src/precompiles/utils.rs 90.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell
Copy link
Collaborator Author

refcell commented Feb 6, 2025

Darn rust-analyzer must have automatically enabled blst feature... forgot bls12_381 module in revm is hidden behind blst. This is blocking. Once solution may be to PR into revm and try to hoist these constants to the parent module so they can be used without blst being enabled.

@refcell refcell marked this pull request as draft February 6, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant