Audio improvements #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cleaned up accessibility of Decoder attributes - added option to ask for custom audio_fps and audio_nbytes when loading media from file - added option to set Moviepy VideoFileClip directly (for custom external clip processing before playing with mediadecoder) - added parameter `pygame_buffersize` to PygameSoundrenderer init (for using a Pygame mixer buffersize smaller than the size of one video frame, which will improve video/audio synchronization) - added conversion of audio to unsigned int if Pygame mixer uses this format - added conversion of 32 bit in to 32 bit float if Pygame mixer uses this format - fix/hack for 8-bit audio bug in MoviePy (see Zulko/moviepy#2397)
This allows requesting a custom video resolution (as opposed to the one encoded in the video file).
Fix for redundant reloading of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audio_fps,audio_nbytesandaudio_nchannelswhen loading media from filetarget_resolutionwhen loading media from filepygame_buffersizeto PygameSoundrenderer init (for using a Pygame mixer buffersize smaller than the size of one video frame, which will improve video/audio synchronization)