[DO NOT MERGE] [ITEP-82754] POC: Consume Tracker data from MQTT topic by Analytics #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytroye
changed the title
dmytroye
requested review from
Copilot and
tdorauintc
and removed request for
tdorauintc
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements functionality for Analytics to consume tracked object data from MQTT topics published by the Tracker service, replacing direct tracker calls with a message-based approach. The key changes include:
- Adding MQTT subscription handling for tracked object data from the DATA_SCENE topic
- Implementing a caching mechanism for tracked objects received via MQTT with fallback to direct tracker calls
- Adding deserialization logic to convert MQTT message payloads into MovingObject-compatible structures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| controller/src/controller/scene_controller.py | Adds handleSceneDataMessage method to process tracked objects from MQTT and subscribes to DATA_SCENE topic for analytics consumption |
| controller/src/controller/scene.py | Implements tracked objects cache, deserialization logic, and getTrackedObjects method with MQTT-first approach and tracker fallback |
| controller/src/controller/detections_builder.py | Adds frame_count field to object dictionary for analytics tracking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
….com/open-edge-platform/scenescape into dmytroye/subscribe-analytics-to-mqtt
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmytroye
changed the title
…from MQTT - Add _normalize_camera_bounds() to convert int->float for consistency - Extract ref_camera_frame_rate before early returns in analytics mode - Preserve camera_bounds from MQTT in _deserializeTrackedObjects() - Add safety check in computeCameraBounds() for missing visibility key - Add field ordering (similarity, first_seen before camera_bounds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR implements functionality for Analytics to consume tracked object data from MQTT topics published by the Tracker service, replacing direct tracker calls with a message-based approach. The key changes include:
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: