Skip to content

Conversation

@saratpoluri
Copy link
Contributor

📝 Description

This PR makes the following changes:
ITEP-83949: When calling the scene update endpoint, the sceneID is removed from the API call parameters.
ITEP-83950: MEDIA_ROOT for web app is /workspace/media and not /home/scenescape/Scenescape/media.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@saratpoluri saratpoluri requested review from Irakus and Copilot January 12, 2026 18:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses two issues related to scene management functionality: correcting an API call parameter and fixing the media root path configuration.

Changes:

  • Removes the scene field from the scene update API call parameters in the JavaScript frontend
  • Updates MEDIA_ROOT configuration to use an environment variable with /workspace/media as the default instead of a hardcoded path

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
manager/src/static/js/thing/scene.js Removes scene: this.sceneID from the sceneData object in the saveSettings() method
manager/src/django/settings.py Changes MEDIA_ROOT from a hardcoded path to use os.getenv() with /workspace/media as the default value

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@tdorauintc tdorauintc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is working fine when GLB file is loaded.

It seems to break something when scene is imported with GLB file. After a scene is imported with GLB file, docker compose down; docker compose up -d sequence results in web container failure (I checked it on OOB Queuing scene with GLB file loaded as a map - scene export, scene & cameras removal, scene import, deployment restart).

I haven't debugged it deeper but this issue is not reproducible on main, so it is apparently introduced by the PR changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants