Introducing Just scripts #5171
Introducing Just scripts #5171
Conversation
warrkan
requested review from
a team,
Radwan-Ibrahim,
leoll2 and
samet-akcay
as code owners
github-actions
bot
added
BUILD
Geti Tune Backend
Docker Image SizesCPU
GPU
XPU
|
📊 Test coverage report
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| docker-build-context := "" | ||
| build-target := "cpu" # options: cpu, gpu, xpu | ||
| component-name := "geti-tune" | ||
| container-registry := 'localhost:5000/open-edge-platform' |
There was a problem hiding this comment.
Why this won't target our default ghcr registry that we will push images to? Or at least dev ghcr registry?
There was a problem hiding this comment.
This is done similar to Geti Prompt. But I can change it if needed
| docker-build-args := "--build-arg http_proxy --build-arg https_proxy --build-arg no_proxy --build-arg HTTP_PROXY --build-arg HTTPS_PROXY --build-arg NO_PROXY" | ||
| docker-run-args := "--env http_proxy --env https_proxy --env no_proxy --env HTTP_PROXY --env HTTPS_PROXY --env NO_PROXY" |
There was a problem hiding this comment.
Why by default are we adding proxy args/envs to docker build cmd? Will our builders be behind some proxy?
There was a problem hiding this comment.
Similar to previous comment - this is similar approach with Geti Prompt
Adding Just scripts for application and library linting, fixing style checks, testing and building
Adjusting Github Actions to use these scripts