Enable Pyrefly in Geti Tune #5178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEPENDENCY
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces mypy with Pyrefly as the static type checker for the Geti Tune application backend. The change updates CI workflows and pre-commit configurations, while adding Pyrefly-specific type ignore comments throughout the codebase to address type checking issues identified by the new tool.
Changes:
- Replaced mypy with Pyrefly (~0.46.3) in project dependencies and configurations
- Added Pyrefly ignore comments to address type checking issues across multiple files
- Removed redundant null-checking tests and simplified type annotations
- Updated model definitions to support better type inference with generics
Reviewed changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| application/backend/pyproject.toml | Replaced mypy dependency with Pyrefly and updated configuration |
| .github/workflows/backend-lint-and-test.yaml | Updated CI workflow to use Pyrefly instead of mypy |
| application/backend/.pre-commit-config.yaml | Updated pre-commit hooks to use Pyrefly |
| application/backend/app/utils/visualization.py | Added type generics and Pyrefly ignore comments |
| application/backend/app/core/jobs/models/job.py | Introduced JobParamsT TypeVar for better type safety |
| application/backend/app/models/dataset_item.py | Changed subset field default from nullable to UNASSIGNED |
| application/backend/tests/unit/test_visualization.py | Removed redundant null-checking tests |
| Multiple service and API files | Added Pyrefly ignore comments for type checking issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AlexanderBarabanov
previously approved these changes
Jan 13, 2026
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables Pyrefly as a static type checker for the Python code in Geti Tune (application), replacing mypy.
CI workflows and pre-commit checks are updated accordingly.
Resolves #5169
How to test
Checklist