Skip to content

Conversation

@jpggvilaca
Copy link
Contributor

Summary

  • Remove UI's that wont be supported by the backend
  • Add parent revision logic
  • Add new hook
  • Add ModelListingProvider and replace all prop drilling
  • Layout updates
  • Improve mocks
  • Integrate model endpoints

Next: Training datasets (last tab) & tests

How to test

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@jpggvilaca jpggvilaca requested a review from a team as a code owner January 14, 2026 15:57
@jpggvilaca jpggvilaca added the Geti Tune UI Issues related to Geti Tune UI label Jan 14, 2026
Copilot AI review requested due to automatic review settings January 14, 2026 15:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates model API endpoints and refactors the model listing feature to use a context provider pattern instead of prop drilling. The changes include removing unsupported UI elements, implementing parent revision logic for model relationships, improving mock data, and integrating real API endpoints for model data.

Changes:

  • Introduced ModelListingProvider context to manage state and eliminate prop drilling throughout the component tree
  • Added useGetModel hook and parent revision logic to display model relationships
  • Removed unsupported UI elements (menus, links) and replaced with appropriate components
  • Extracted reusable MetricGraph component from duplicated chart code

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
application/ui/src/features/models/model-listing/provider/model-listing-provider.tsx New context provider for model listing state management
application/ui/src/features/models/model-listing/model-listing.container.tsx Simplified container to wrap component with provider
application/ui/src/features/models/model-listing/model-listing.component.tsx Removed props in favor of context hook
application/ui/src/features/models/model-listing/components/header.component.tsx Updated to use context instead of props
application/ui/src/features/models/model-listing/components/group-models-container.component.tsx Added expansion state management using context
application/ui/src/features/models/model-listing/components/model-row.component.tsx Implemented parent revision display and formatting
application/ui/src/features/models/model-listing/components/models-table-header.component.tsx Updated to use context hook
application/ui/src/features/models/model-listing/components/group-headers/*.tsx Removed unsupported menu components
application/ui/src/features/models/model-listing/components/three-section-range.component.tsx Changed Link to Text component
application/ui/src/features/models/model-listing/model-metrics/*.tsx Extracted reusable MetricGraph component
application/ui/src/features/models/model-listing/utils/grouping.ts Added date formatting and updated dataset display logic
application/ui/src/features/models/model-listing/utils/date-formatting.ts New utility for formatting training date/time
application/ui/src/features/models/hooks/api/use-get-model.hook.ts New hook to fetch individual model data
application/ui/mocks/mock-model.ts Enhanced mock data with realistic values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

📊 Test coverage report

Metric Coverage
Lines 38.8%
Functions 35.0%
Branches 86.0%
Statements 38.8%

@github-actions
Copy link

Docker Image Sizes

CPU

Image Size
geti-tune-cpu:pr-5205 2.88G
geti-tune-cpu:sha-ffe9bd6 2.88G

GPU

Image Size
geti-tune-gpu:pr-5205 10.66G
geti-tune-gpu:sha-ffe9bd6 10.66G

XPU

Image Size
geti-tune-xpu:pr-5205 8.72G
geti-tune-xpu:sha-ffe9bd6 8.72G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti Tune UI Issues related to Geti Tune UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants