-
Notifications
You must be signed in to change notification settings - Fork 462
API integration part 2 #5205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
API integration part 2 #5205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR integrates model API endpoints and refactors the model listing feature to use a context provider pattern instead of prop drilling. The changes include removing unsupported UI elements, implementing parent revision logic for model relationships, improving mock data, and integrating real API endpoints for model data.
Changes:
- Introduced
ModelListingProvidercontext to manage state and eliminate prop drilling throughout the component tree - Added
useGetModelhook and parent revision logic to display model relationships - Removed unsupported UI elements (menus, links) and replaced with appropriate components
- Extracted reusable
MetricGraphcomponent from duplicated chart code
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/src/features/models/model-listing/provider/model-listing-provider.tsx | New context provider for model listing state management |
| application/ui/src/features/models/model-listing/model-listing.container.tsx | Simplified container to wrap component with provider |
| application/ui/src/features/models/model-listing/model-listing.component.tsx | Removed props in favor of context hook |
| application/ui/src/features/models/model-listing/components/header.component.tsx | Updated to use context instead of props |
| application/ui/src/features/models/model-listing/components/group-models-container.component.tsx | Added expansion state management using context |
| application/ui/src/features/models/model-listing/components/model-row.component.tsx | Implemented parent revision display and formatting |
| application/ui/src/features/models/model-listing/components/models-table-header.component.tsx | Updated to use context hook |
| application/ui/src/features/models/model-listing/components/group-headers/*.tsx | Removed unsupported menu components |
| application/ui/src/features/models/model-listing/components/three-section-range.component.tsx | Changed Link to Text component |
| application/ui/src/features/models/model-listing/model-metrics/*.tsx | Extracted reusable MetricGraph component |
| application/ui/src/features/models/model-listing/utils/grouping.ts | Added date formatting and updated dataset display logic |
| application/ui/src/features/models/model-listing/utils/date-formatting.ts | New utility for formatting training date/time |
| application/ui/src/features/models/hooks/api/use-get-model.hook.ts | New hook to fetch individual model data |
| application/ui/mocks/mock-model.ts | Enhanced mock data with realistic values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/models/model-listing/utils/date-formatting.ts
Outdated
Show resolved
Hide resolved
application/ui/src/features/models/model-listing/utils/grouping.ts
Outdated
Show resolved
Hide resolved
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
Summary
Next: Training datasets (last tab) & tests
How to test
Checklist