-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaked Path class #12
Comments
In #17, adding the related macros shows that the devices instantiated are actually what is leaking, but I can't figure out exactly where they are leaking. There are no additional classes that are registered as being leaked, indicating it is something with the device pointers themselves. Specifically, the following lines can be removed to fix the leak, but then nothing downstream happens: onix-source/Source/OnixSource.cpp Lines 169 to 243 in d9d4918
If these lines are left in, I have tried to selectively remove lines from other classes to find the leak, such as removing the lines that create the interfaces in OnixSourceCanvas, but none of these modifications fix it. Prior to f8d65b2, I don't remember this being an issue. However, cherry-picking changes from this commit do not seem to fix the issue, so maybe it started occurring prior to this and I did not notice. |
Somewhere in creating the OnixSourceCanvas, specifically the device interfaces for Neuropixels 1.0f (i.e.,
Bno055Interface
andNeuropixV1Interface
), there is a leaked Path. Initial testing also indicated that there are device classes leaked from these interfaces. Figure out where the issue is coming from, and plug the leak.See #11 for a related issue.
The text was updated successfully, but these errors were encountered: