Add leak detectors to all classes #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up confusing variable names - Remove local declarations of variables that can be easily accessed via pointer
Closed
|
Closing this PR, the actual memory leak is closed in PR #24 by changing to vectors of smart pointers, and all relevant changes that were initially here have been ported there to make it easier to test and review PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make #12 easier to fix, this PR adds leak detectors to all classes. There is also some code cleanup related to these classes, renaming variables so they are less confusing, and removing local declarations of variables if they can be easily accessed via pointer.