Check Port Status during acquisition #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PortController as an OnixDevice, implement the necessary methods - Add PortController devices to the FrameReader so the IDs are processed
jonnew
previously requested changes
Mar 7, 2025
There was a problem hiding this comment.
During our meeting we found that since this error originates in updateBuffer(), the shutdown process may be actually being executed by the DataThread which seems to be resulting in some multithreading issues. More investigation is needed to make sure that the system shuts down properly if lock is lost during acquisition.
- Correctly parses the data frame from a Port Controller - Run startAcquisition for the port control devices - Modified language when unable to acquire the communication lock
- Rename enableDevice to configureDevice - Only update Neuropixels settings when the device is enabled
- Upon testing, the previous configuration could delete buffers before they were cleared, leading to invalid behavior. Now, the plugin reports that it cannot record so the user cannot start acquisition again without disconnecting/reconnecting the hardware
aacuevas
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
PortControlleras a fullOnixDevice, which allows it to add and process frames during acquisition. This device is not expected to receive frames very often, or really ever, unless something happens and the lock is lost. If this occurs, anerrorFlagis raised in the specific Port device, and acquisition is halted.Before merging; please confirm that if the lock is lost the behavior stops as expected. e.g., cut power to the port during acquisition and confirm behavior. This is difficult for me to do remotely.