Fix np2 scaling factor #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I believe the previous scaling factor was result from misleading information from np2 datasheet
bparks13
approved these changes
Jan 29, 2025
Member
bparks13
left a comment
bparks13
left a comment
There was a problem hiding this comment.
I have no way to test this empirically, but as long as you are confident with the results you can merge it
Member
Author
|
This value came from jsiegle in this PR. I'm fairly confident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the previous scaling factor was result from misleading information from np2 datasheet. The updated one is the value empirically measured.