Conversation
Member
jonnew
commented
Jan 17, 2025
jonnew
commented
- The ConfigureUCLAMiniscopeV4Camera passthrough configuration assumed that passthrough device registers were defaulted prior to configuring the device to receive miniscope data. If the passthrough device was used for something else (e.g. neuropixels headstage) before this, then this would not be the case. Now we explicitly set all passthrough registers in ConfigureUCLAMiniscopeV4Camera to the correct values.
- Fixes Miniscope not sending camera data, but can be controlled and IMU sensor data acquired #402
- The ConfigureUCLAMiniscopeV4Camera passthrough configuration assumed that passthrough device registers were defaulted prior to configuring the device to receive miniscope data. If the passthrough device was used for something else (e.g. neuropixels headstage) before this, then this would not be the case. Now we explicitly set all passthrough registers in ConfigureUCLAMiniscopeV4Camera to the correct values.
aacuevas
previously requested changes
Jan 17, 2025
Collaborator
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
DS90UB9x.MAGIC should be also set to 0 for safety. Apart from that, seems good.
- This was missing in the previous commit
Member
Author
|
Oops, should be good now. @bparks13 I think this is ready |
bparks13
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.