Skip to content

Map Rhd2164 ephys channels into Intan order #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Map Rhd2164 ephys channels into Intan order #433

wants to merge 3 commits into from

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Apr 18, 2025 •
edited
Loading

@jonnew
Map Rhd2164 ephys channels into Intan order
34adebc 
- Added a BufferHelper.CopyTranspose specialization that takes a channel
  map
@jonnew jonnew requested a review from bparks13 April 18, 2025 16:22
@jonnew
Copy link
Member Author

jonnew commented Apr 18, 2025

I need to test this in hardware still.

@jonnew jonnew added this to the 0.5.0 milestone Apr 18, 2025
@jonnew
Fixes to Rhd2164 channel map during hardware test
ec494aa 
- Previous implementation did not function
- Updated Rhd2164DataFrame docs to specify channel ordering
@jonnew
Copy link
Member Author

jonnew commented Apr 21, 2025

This is now verified to work well in hardware. Mi not super happy with how inefficient this implementation is: it seems like the the transpose and remapping could occur in the single step (kind of like the naive first implementation), but the open cv binding wont allow it because the CV.Copy() function requires the source and destination to have the same shape even if they have the same memory size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 Awaiting requested review from bparks13

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Remap Rhd2164 data frame channels Default Channel configuration for Headstage64 RHD2164 device
1 participant
@jonnew