Skip to content

Add support for stimulus reports on headstage-64#504

Merged
jonnew merged 2 commits intomainfrom
issue-384
Sep 25, 2025
Merged

Add support for stimulus reports on headstage-64#504
jonnew merged 2 commits intomainfrom
issue-384

Conversation

@jonnew
Copy link
Member

@jonnew jonnew commented Sep 22, 2025

- The electrical and optical stimulation devices on headstage-64 now
  send reports, if the data stream is enabled, for all delivered
  stimuli making it very easy to have sychronized stimulus timing
  information
- This is supported on version 3 of the of the devices
@jonnew jonnew added this to the 0.7.0 milestone Sep 22, 2025
@jonnew jonnew requested review from bparks13 and cjsha September 22, 2025 18:30
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a couple minor fixes in the XML comments / descriptions.

@bparks13
Copy link
Member

@jonnew Issue #503 has been tagged as being completed by this PR because of the word "resolve" in front of it. We will need to unlink that issue before merging so that it stays open.

@jonnew jonnew removed the request for review from cjsha September 24, 2025 23:15
@jonnew
Copy link
Member Author

jonnew commented Sep 24, 2025

Note to self: optical stimulator configuration does not implement data enable register.

- Address review comments
- Fix several typos
@jonnew jonnew merged commit da6ef61 into main Sep 25, 2025
8 checks passed
@jonnew jonnew deleted the issue-384 branch September 25, 2025 17:27
bparks13 added a commit that referenced this pull request Jan 12, 2026
This reverts commit da6ef61, reversing
changes made to a2b1bde.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardware timestamp when a stimulation is triggered and save stimulation waveform parameters

2 participants