Conversation
Member
jonnew
commented
Sep 25, 2025
jonnew
commented
- Add a minimum version for all static device classes in this library along with a minimum version check against detected hardware version
- Fixes Add minimum device version check #503
- Add a minimum version for all static device classes in this library along with a minimum version check against detected hardware version
aacuevas
reviewed
Sep 26, 2025
aacuevas
approved these changes
Sep 26, 2025
Collaborator
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
Just a minor nitpick,. but looks good.
- This address review comments by providing information on what to do about how to address the firmware issue without corrupting the purity of the exception message which should only describe the problem.
aacuevas
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.