Refactor Neuropixels 2.0 probes in preparation for single-shank probes #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aacuevas
requested changes
Nov 3, 2025
Collaborator
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
I left a couple of comments, but there are other parts where these same comments are still true.
In short, while it is in general a good abstraction effort, there are some places where separation of responsibilities is broken and the general classes include switches of the specifics, which is not a good pattern.
OpenEphys.Onix1.Design/NeuropixelsV2eProbeConfigurationDialog.cs
Outdated
Show resolved
Hide resolved
OpenEphys.Onix1.Design/NeuropixelsV2eProbeConfigurationDialog.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@aacuevas I have updated the implementation as we discussed, and tested it out. There is no difference in behavior, but this is definitely a cleaner separation between responsibilities, and should translate well when I add in the single-shank probe. Let me know if this looks good, and I can rebase the other branch to make use of these changes. |
- Add Neuropixels V2 probe info interfaces and implementations - Moved all probe-specific logic from the dialog to the info class in the Design library - Update all methods/classes to handle the abstract class, with easy scalability to add single-shank probes in the future - Add clone method for NeuropixelsV2eProbeGroup to ensure that dialogs can be exited without affecting settings - Update how the ChannelMap is accessed and utilized
bparks13
force-pushed
the
refactor-npx2-config
branch
from
d37589c to
5db06c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was initially a part of #493; it has been split out into this PR as well so that we can review the underlying infrastructural changes independently of the addition of the single-shank Neuropixels 2.0 probes. This is prompted by #522, which would benefit from some of these changes but we do not need the single-shank probes for #522 to be implemented.
Below are the major highlights of this PR: