-
Notifications
You must be signed in to change notification settings - Fork 5
Add basic troubleshooting step when lock cannot be acquired #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aacuevas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the manual voltage message, I'd write something like
"If the problem persists, you may need..." or something
Make it clear that port checking should go first. Writing a big value there is dangerous, so we need to make it clear that it's not something to try lightly
|
imo, the wording should be more severe or suggest more caution than it currently does. |
| $"Unable to acquire communication lock on {portString}. You may need to manually specify a PortVoltage greater than {PortVoltage.Applied} volts, the maximum automatic value for this device."; | ||
| $"Unable to acquire communication lock on {portString}. Confirm the headstage port is turned on." : | ||
| $"Unable to acquire communication lock on {portString}. Confirm the headstage port is turned on." | ||
| + $"\n\nYou may need to manually specify a PortVoltage greater than {PortVoltage.Applied} volts, the maximum automatic value for this device."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wary to recommend applying a higher voltage than the maximum automatic value without caveats about how this should only need to be done in experiments that involve extra long/thin wires or something like that. But this might require more explanation than what we'd want in an exception dialog or whateva.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It's a fine line between being informative enough and too verbose. And it's unfortunate that we cannot add working links to the dialog, so we cannot just link to an explanation website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to add a link so that we can move the nuance from the pop-up to a web browser, I can create a custom message box with a LinkLabel so we can link out to the documentation. That might be outside the scope of this current issue, but we can move the discussion to a new issue and work out the specifics there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, this message is being passed up to the Bonsai exception handler. Unable to create a custom message box
For all port controllers, if communication lock cannot be acquired add a line with the basic step of "Confirm the headstage port is turned on".
Fixes #496