Remove Range attribute for ConfigurePersistentHeartbeat.BeatsPerSecond#570
Merged
Remove Range attribute for ConfigurePersistentHeartbeat.BeatsPerSecond#570
Conversation
- The range is a readonly register value that is device specific and not know at compile time
Member
|
Its not a read only register. It has a minimum and max that are defined by the hardware. The enable is a read only register though. It can produce data more or less frequently, it just cant be turned off. I do agree that its gross to have a range on there that is not informed by the hardware's internal bounds. Edit: although this is true, it has nothing to do with the reasoning behind the commit. |
jonnew
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was cherry-picked from PR #529.