Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packaging issues impacting babel/react #596

Merged
merged 8 commits into from
Sep 29, 2023
Merged

fix: packaging issues impacting babel/react #596

merged 8 commits into from
Sep 29, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 28, 2023

  • run nx migrations we missed
  • update nx again (with new migrations)
  • remove "type": "module" from all package.jsons (let nx handle it, this was the bug)
  • ADDS ability to generate CLIENT packages (with new prompt)

I've tested this in:

  • create-react app
  • an esm node project
  • a commonjs node project

Fixes: #597

@toddbaert toddbaert marked this pull request as draft September 28, 2023 17:11
@toddbaert toddbaert marked this pull request as ready for review September 29, 2023 13:53
@toddbaert toddbaert changed the title fix: re-run nx migrations we missed fix: packaging issues impacting babel/react Sep 29, 2023
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
Copy link
Member Author

@beeme1mr updated generators/templates look good, thanks for fixing that.

Merging. I will release the goff web provider ASAP because it's broken.

@toddbaert toddbaert merged commit 0446eab into main Sep 29, 2023
@toddbaert toddbaert deleted the fix/packaging branch September 29, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import web contrib projects in create-react-app
7 participants