Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packaging issues impacting babel/react #596

Merged
merged 8 commits into from
Sep 29, 2023
Merged

fix: packaging issues impacting babel/react #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3250a0d
fix: re-run nx migrations we missed
toddbaert Sep 28, 2023
4fa79bc
Merge branch 'main' into fix/packaging
toddbaert Sep 28, 2023
ab147b5
fixup: remove type in all package.jsons
toddbaert Sep 29, 2023
a2a7b82
fixup: prompt
toddbaert Sep 29, 2023
61be2c4
fixup: generator
toddbaert Sep 29, 2023
c6ccf3b
add client/server provider templates
beeme1mr Sep 29, 2023
fb542af
add client/server hook templates
beeme1mr Sep 29, 2023
506e749
add client/server template generation
beeme1mr Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions libs/hooks/open-telemetry/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
"targets": {
"package": {
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"project": "libs/hooks/open-telemetry/package.json",
"outputPath": "dist/libs/hooks/open-telemetry",
Expand All @@ -16,7 +18,10 @@
"generateExportsField": true,
"umdName": "OpenTelemetry",
"external": "all",
"format": ["cjs", "esm"],
"format": [
"cjs",
"esm"
],
"assets": [
{
"glob": "package.json",
Expand All @@ -39,12 +44,16 @@
},
"build": {
"executor": "@nx/js:tsc",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"outputPath": "dist/libs/hooks/open-telemetry",
"main": "libs/hooks/open-telemetry/src/index.ts",
"tsConfig": "libs/hooks/open-telemetry/tsconfig.lib.json",
"assets": ["libs/hooks/open-telemetry/*.md"],
"assets": [
"libs/hooks/open-telemetry/*.md"
],
"updateBuildableProjectDepsInPackageJson": true
}
},
Expand All @@ -62,14 +71,20 @@
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": ["libs/hooks/open-telemetry/**/*.ts"]
"lintFilePatterns": [
"libs/hooks/open-telemetry/**/*.ts"
]
}
},
"test": {
"executor": "@nx/jest:jest",
"outputs": ["coverage/libs/hooks/open-telemetry"],
"outputs": [
"{workspaceRoot}/coverage/libs/hooks/open-telemetry"
],
"options": {
"jestConfig": "libs/hooks/open-telemetry/jest.config.ts",
"passWithNoTests": true,
Expand Down
1 change: 0 additions & 1 deletion libs/providers/config-cat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@openfeature/config-cat-provider",
"version": "0.3.0",
"type": "commonjs",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
Expand Down
21 changes: 16 additions & 5 deletions libs/providers/config-cat/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,20 @@
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": ["libs/providers/config-cat/**/*.ts"]
"lintFilePatterns": [
"libs/providers/config-cat/**/*.ts"
]
}
},
"test": {
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"outputs": [
"{workspaceRoot}/coverage/{projectRoot}"
],
"options": {
"jestConfig": "libs/providers/config-cat/jest.config.ts",
"passWithNoTests": true
Expand All @@ -39,7 +45,9 @@
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"project": "libs/providers/config-cat/package.json",
"outputPath": "dist/libs/providers/config-cat",
Expand All @@ -50,7 +58,10 @@
"generateExportsField": true,
"umdName": "config-cat",
"external": "all",
"format": ["cjs", "esm"],
"format": [
"cjs",
"esm"
],
"assets": [
{
"glob": "package.json",
Expand Down
1 change: 0 additions & 1 deletion libs/providers/env-var/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@openfeature/env-var-provider",
"version": "0.1.1",
"type": "commonjs",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
Expand Down
21 changes: 16 additions & 5 deletions libs/providers/env-var/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,20 @@
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": ["libs/providers/env-var/**/*.ts"]
"lintFilePatterns": [
"libs/providers/env-var/**/*.ts"
]
}
},
"test": {
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"outputs": [
"{workspaceRoot}/coverage/{projectRoot}"
],
"options": {
"jestConfig": "libs/providers/env-var/jest.config.ts",
"passWithNoTests": true
Expand All @@ -39,7 +45,9 @@
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"project": "libs/providers/env-var/package.json",
"outputPath": "dist/libs/providers/env-var",
Expand All @@ -50,7 +58,10 @@
"generateExportsField": true,
"umdName": "Env Var",
"external": "all",
"format": ["cjs", "esm"],
"format": [
"cjs",
"esm"
],
"assets": [
{
"glob": "package.json",
Expand Down
1 change: 0 additions & 1 deletion libs/providers/flagd-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@openfeature/flagd-web-provider",
"version": "0.4.0",
"type": "commonjs",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
Expand Down
21 changes: 16 additions & 5 deletions libs/providers/flagd-web/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": ["libs/providers/flagd-web/**/*.ts"]
"lintFilePatterns": [
"libs/providers/flagd-web/**/*.ts"
]
},
"dependsOn": [
{
Expand All @@ -43,7 +47,9 @@
},
"test": {
"executor": "@nx/jest:jest",
"outputs": ["coverage/libs/providers/flagd-web"],
"outputs": [
"{workspaceRoot}/coverage/libs/providers/flagd-web"
],
"options": {
"jestConfig": "libs/providers/flagd-web/jest.config.ts",
"passWithNoTests": true
Expand Down Expand Up @@ -86,7 +92,9 @@
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"project": "libs/providers/flagd-web/package.json",
"outputPath": "dist/libs/providers/flagd-web",
Expand All @@ -97,7 +105,10 @@
"buildableProjectDepsInPackageJsonType": "dependencies",
"umdName": "flagd-web",
"external": "all",
"format": ["cjs", "esm"],
"format": [
"cjs",
"esm"
],
"assets": [
{
"glob": "package.json",
Expand Down
21 changes: 16 additions & 5 deletions libs/providers/flagd/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": ["libs/providers/flagd/**/*.ts"]
"lintFilePatterns": [
"libs/providers/flagd/**/*.ts"
]
},
"dependsOn": [
{
Expand All @@ -43,7 +47,9 @@
},
"test": {
"executor": "@nx/jest:jest",
"outputs": ["coverage/libs/providers/flagd"],
"outputs": [
"{workspaceRoot}/coverage/libs/providers/flagd"
],
"options": {
"jestConfig": "libs/providers/flagd/jest.config.ts",
"passWithNoTests": true
Expand Down Expand Up @@ -86,7 +92,9 @@
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"project": "libs/providers/flagd/package.json",
"outputPath": "dist/libs/providers/flagd",
Expand All @@ -97,7 +105,10 @@
"buildableProjectDepsInPackageJsonType": "dependencies",
"umdName": "flagd",
"external": "all",
"format": ["cjs", "esm"],
"format": [
"cjs",
"esm"
],
"assets": [
{
"glob": "package.json",
Expand Down
4 changes: 3 additions & 1 deletion libs/providers/flagd/src/lib/flagd-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export class FlagdProvider implements Provider {
name: 'flagd Provider',
};

readonly runsOn = 'server';

get status() {
return this._status;
}
Expand All @@ -31,7 +33,7 @@ export class FlagdProvider implements Provider {

/**
* Construct a new flagd provider.
*
*
* @param options options, see {@link FlagdProviderOptions}
* @param logger optional logger, see {@link Logger}
* @param service optional internal service implementation, should not be needed for production
Expand Down
1 change: 0 additions & 1 deletion libs/providers/go-feature-flag-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@openfeature/go-feature-flag-web-provider",
"version": "0.1.3",
"type": "commonjs",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
Expand Down
22 changes: 16 additions & 6 deletions libs/providers/go-feature-flag-web/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,26 @@
},
"dependsOn": [
{
"projects": "self",
"target": "package"
}
]
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": ["{options.outputFile}"],
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": ["libs/providers/go-feature-flag-web/**/*.ts"]
"lintFilePatterns": [
"libs/providers/go-feature-flag-web/**/*.ts"
]
}
},
"test": {
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"outputs": [
"{workspaceRoot}/coverage/{projectRoot}"
],
"options": {
"jestConfig": "libs/providers/go-feature-flag-web/jest.config.ts",
"passWithNoTests": true
Expand All @@ -40,7 +45,9 @@
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"outputs": [
"{options.outputPath}"
],
"options": {
"project": "libs/providers/go-feature-flag-web/package.json",
"outputPath": "dist/libs/providers/go-feature-flag-web",
Expand All @@ -51,7 +58,10 @@
"generateExportsField": true,
"umdName": "go-feature-flag-web",
"external": "all",
"format": ["cjs", "esm"],
"format": [
"cjs",
"esm"
],
"assets": [
{
"glob": "package.json",
Expand Down
Loading