Skip to content

chore(main): release ofrep-web-provider 0.4.0#1535

Open
openfeaturebot wants to merge 1 commit into
mainfrom
release-please--branches--main--components--ofrep-web-provider
Open

chore(main): release ofrep-web-provider 0.4.0#1535
openfeaturebot wants to merge 1 commit into
mainfrom
release-please--branches--main--components--ofrep-web-provider

Conversation

@openfeaturebot
Copy link
Copy Markdown
Contributor

@openfeaturebot openfeaturebot commented Apr 30, 2026

🤖 I have created a release beep boop

0.4.0 (2026-05-13)

⚠ BREAKING CHANGES

  • ofrep: Disable polling by default (#1510)

🐛 Bug Fixes

  • ofrep-web: fall back to FNV-1a hash when crypto.subtle is unavailable (#1549) (00b2457)

✨ New Features


This PR was generated with Release Please. See documentation.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @openfeature/ofrep-web-provider to version 0.3.7 and adds a changelog entry for a new local persistence feature. Feedback indicates that the implementation of this feature relies on the Web Crypto API, which requires a secure context and may fail in non-secure environments; a fallback mechanism is suggested. Furthermore, the version bump should be a minor update (0.4.0) rather than a patch (0.3.7) to comply with Semantic Versioning for new features.


### ✨ New Features

* added local persistence to ofrep-web provider ([#1508](https://github.com/open-feature/js-sdk-contrib/issues/1508)) ([3103f2c](https://github.com/open-feature/js-sdk-contrib/commit/3103f2cb92037886ee32a2076542a717b4fcc52f))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The implementation of the 'local persistence' feature in libs/providers/ofrep-web/src/lib/store/storage.ts uses crypto.subtle.digest, which is only available in secure contexts (HTTPS). This will cause the provider to throw an error during store operations in non-secure environments (e.g., local development on non-localhost IP addresses or older browsers), which in turn causes initialize to fail because the error is re-thrown in _fetchFlags.

Consider adding a check for crypto.subtle and providing a fallback hashing mechanism or wrapping the storage operations in a way that allows the provider to continue without persistence if the crypto API is unavailable.

Comment thread libs/providers/ofrep-web/package.json Outdated
{
"name": "@openfeature/ofrep-web-provider",
"version": "0.3.6",
"version": "0.3.7",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version is being bumped to 0.3.7 (a patch increase), but the changelog indicates that a new feature ('local persistence') was added. According to Semantic Versioning (SemVer), adding a new backwards-compatible feature should trigger a minor version bump (e.g., to 0.4.0). Since this PR was generated by release-please, this might suggest that the commit introducing the feature was not prefixed with feat:. Consider updating the version to 0.4.0 to reflect the addition of a new feature.

@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--ofrep-web-provider branch from 2e48bdc to 9a8c0f7 Compare May 1, 2026 12:26
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--ofrep-web-provider branch 2 times, most recently from 3fca1b0 to 405dbee Compare May 11, 2026 11:51
@openfeaturebot openfeaturebot changed the title chore(main): release ofrep-web-provider 0.3.7 chore(main): release ofrep-web-provider 0.4.0 May 12, 2026
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--ofrep-web-provider branch from 405dbee to efc5d4f Compare May 12, 2026 19:49
@beeme1mr
Copy link
Copy Markdown
Member

@MattIPv4, you may want to watch this PR to get notified when it gets released.

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--ofrep-web-provider branch from efc5d4f to a1965a7 Compare May 13, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants