chore(main): release ofrep-web-provider 0.4.0#1535
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the @openfeature/ofrep-web-provider to version 0.3.7 and adds a changelog entry for a new local persistence feature. Feedback indicates that the implementation of this feature relies on the Web Crypto API, which requires a secure context and may fail in non-secure environments; a fallback mechanism is suggested. Furthermore, the version bump should be a minor update (0.4.0) rather than a patch (0.3.7) to comply with Semantic Versioning for new features.
|
|
||
| ### ✨ New Features | ||
|
|
||
| * added local persistence to ofrep-web provider ([#1508](https://github.com/open-feature/js-sdk-contrib/issues/1508)) ([3103f2c](https://github.com/open-feature/js-sdk-contrib/commit/3103f2cb92037886ee32a2076542a717b4fcc52f)) |
There was a problem hiding this comment.
The implementation of the 'local persistence' feature in libs/providers/ofrep-web/src/lib/store/storage.ts uses crypto.subtle.digest, which is only available in secure contexts (HTTPS). This will cause the provider to throw an error during store operations in non-secure environments (e.g., local development on non-localhost IP addresses or older browsers), which in turn causes initialize to fail because the error is re-thrown in _fetchFlags.
Consider adding a check for crypto.subtle and providing a fallback hashing mechanism or wrapping the storage operations in a way that allows the provider to continue without persistence if the crypto API is unavailable.
| { | ||
| "name": "@openfeature/ofrep-web-provider", | ||
| "version": "0.3.6", | ||
| "version": "0.3.7", |
There was a problem hiding this comment.
The version is being bumped to 0.3.7 (a patch increase), but the changelog indicates that a new feature ('local persistence') was added. According to Semantic Versioning (SemVer), adding a new backwards-compatible feature should trigger a minor version bump (e.g., to 0.4.0). Since this PR was generated by release-please, this might suggest that the commit introducing the feature was not prefixed with feat:. Consider updating the version to 0.4.0 to reflect the addition of a new feature.
2e48bdc to
9a8c0f7
Compare
3fca1b0 to
405dbee
Compare
405dbee to
efc5d4f
Compare
|
@MattIPv4, you may want to watch this PR to get notified when it gets released. |
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
efc5d4f to
a1965a7
Compare
🤖 I have created a release beep boop
0.4.0 (2026-05-13)
⚠ BREAKING CHANGES
🐛 Bug Fixes
✨ New Features
This PR was generated with Release Please. See documentation.