fix: [GO Feature Flag server] handle PROVIDER_NOT_READY from the spec#505
Merged
thomaspoignant merged 2 commits intomainfrom Jul 31, 2023
Merged
fix: [GO Feature Flag server] handle PROVIDER_NOT_READY from the spec#505thomaspoignant merged 2 commits intomainfrom
thomaspoignant merged 2 commits intomainfrom
Conversation
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
changed the title
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
toddbaert
approved these changes
Jul 31, 2023
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
I've found this testing style to be better for providers, though maybe some people prefer "unit"-level tests.
Looks good!
Member
Author
I'll prefer it too, that's what I've done for other providers but this one the 1st one and I haven't done it properly the 1st time :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR