Skip to content

Issue-114: (Docs) Added FAQ for updating constraints via hzn cli #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Abhijay007
Copy link
Contributor

Signed-off-by: Abhijay Jain [email protected]

Description

Added FAQ for updating constraint of an existing deployment policy via hzn cli

Fixes #114

Type of change

code and docs

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

tested locally by running the server

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@Abhijay007 Abhijay007 requested review from Rene-Ch1 and joewxboy March 30, 2022 21:14
@joewxboy joewxboy changed the title Issue-114 (Docs) : Added FAQ for updating constraints via hzn cli Issue-114: (Docs) Added FAQ for updating constraints via hzn cli Mar 31, 2022
Copy link
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you needed to escape the target of underscore blank. We may need to document this elsewhere when we discuss external links.

@joewxboy joewxboy merged commit b747400 into open-horizon:master Mar 31, 2022
@johnwalicki
Copy link
Member

I like the linting updates in this commit.

This additional FAQ about deployment policies seems misplaced however. That's a low level detail that might be better off in the
"Deployment Policy Use Cases" page at
https://github.com/open-horizon/open-horizon.github.io/blob/master/docs/using_edge_services/policy_user_cases.md
which lands here:
https://open-horizon.github.io/docs/using_edge_services/policy_user_cases.html

@johnwalicki
Copy link
Member

Opened a new issue to move this FAQ entry. #226

@johnwalicki
Copy link
Member

Was the escape on the _underscore a Linter suggestion?
{:target="\_blank"}{: .externalLink}
Technically both are correct and both work. Is there a specific reason we should switch the syntax?

Honestly. I just committed an enormous PR #220 to sync docs and brought these {:target="\_blank"}{: .externalLink} into tons of IEAM pages. Do we need to redo that?

@johnwalicki
Copy link
Member

If both are correct, for stylistic consistency, I'd prefer that it be reverted to the original syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to update constraint of an existing deployment policy via hzn cli?
3 participants