Skip to content

Issue #450 - Fix doc and image links #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

johnwalicki
Copy link
Member

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #450
Fixes $448

Type of change

  • This change requires a documentation update

How Has This Been Tested?

Visit:

Checklist:

  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@johnwalicki johnwalicki requested a review from joewxboy February 27, 2023 18:13
@johnwalicki
Copy link
Member Author

Fixes #448 as well.

@johnwalicki johnwalicki merged commit 03c653f into master Feb 27, 2023
@johnwalicki johnwalicki deleted the issue450-morefixups branch February 27, 2023 19:28
@johnwalicki
Copy link
Member Author

After this PR was merged, I confirmed that the external links are now all correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug🐛: missing externalLink directives
2 participants