Skip to content

Fixed non-transparent backgrounds for emoji only texts #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sabogalc
Copy link

Below is a before and after comparison.
image
image
image
image
I also made the --text-color value equal to var(--background).invert for cases where the emojis only register as squares
image
image

@sabogalc
Copy link
Author

This also works for the ☺️ emoji which for some reason doesn't register on Windows sometimes (also noted here)
image
image

@sabogalc
Copy link
Author

sabogalc commented Aug 2, 2021

I don't want to create another pull request for this, but I do have a new and better solution to this problem. So before, I set --bubble-background in IMChatItem.scss to var(--background), but that resulted in the emoji background cutting off some of the right side of contact photos in group chats, as seen below.
image
to fix this, I set --bubble-background to transparent instead of var(--background), and this is the change that I feel should be implemented. I don't want to create an entirely new pull request for this, so if there's any way to just edit this one or something like that, please let me know. Below is the new and improved fix.
image

@sabogalc
Copy link
Author

sabogalc commented Aug 2, 2021

I tired to make an edit to my transparent backgrounds for images pull request using a similar change to the one I want to make here, but it gave me an error.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant