-
Notifications
You must be signed in to change notification settings - Fork 2
Changed item container max-width
from 70%
to 37%
to render attachments at a smaller size
#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changed item container max-width
from 70%
to 37%
to render attachments at a smaller size
#55
Conversation
… of the acknowledgment menu more dark mode friendly
…mentPicker.scss`
…t, so now I'm undoing that mistake. My bad.
…nts would go transparent
…chments at a smaller size
One unintended/unfortunate side effect of this change is that attachments kind of flash and resize strangely when they load in now. I'm not sure how to go about fixing that. React.Redux.App.-.Brave.2021-06-29.18-26-19.mp4Edit - As far as I can see, this pull request fixed the flashing issue in that the flash is now the same color as the background, so it is not visible. |
I know 37 seems like a super random number, but I tried 35 and it was too small, and I tried 40 and it was too big, so from there I went on to try everything in between, and 37 ended up being the Goldilocks number. As noted in my original feature request, I initially tested this issue by seeing what percentage of horizontal space a specific vertical image took up on the screen. macOS was 36.18%, and iOS was 36.36%, for an average of 36.27%. Between these three numbers, it would make sense that in my internal testing, 35 was too little, and while the numbers to round down to 36, 37 looked better to my naked eye. Maybe we could also just implement a decimal percentage for |
Below are screenshot comparisons between SMServer, macOS, the previous attachment loading in MyMessage, and my changed version. This might not be perfect/final so please let me know what you think of it.







